Skip to content

Adds V2 MSSQL Metrics. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 24, 2022
Merged

Adds V2 MSSQL Metrics. #554

merged 36 commits into from
Jun 24, 2022

Conversation

@StefanKurek
Copy link
Collaborator

@StefanKurek StefanKurek commented Apr 25, 2022

This should be identical with this PR #542, but instead of having a separate app called sqlserver, this adds new metrics to the existing mssql application with a version configuration parameter to differentiate between old and new.

@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 25, 2022
@StefanKurek StefanKurek mentioned this pull request Apr 25, 2022
Closed
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 25, 2022
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@jefferbrecht jefferbrecht mentioned this pull request Apr 26, 2022
Merged
jefferbrecht
jefferbrecht reviewed Apr 26, 2022
View reviewed changes
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 26, 2022
@StefanKurek
Copy link
Collaborator Author

StefanKurek commented Apr 27, 2022

All tests pass:
image

@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 27, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 21, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 21, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 21, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 21, 2022
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 22, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 22, 2022
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 22, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 22, 2022
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 23, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 23, 2022
@qingling128
Copy link
Contributor

qingling128 commented Jun 23, 2022

The failed Windows build is a known issue (fixed separately already).

Once rebased, this can be merged.

@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 24, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 24, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 24, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 24, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 24, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 24, 2022
@schmikei
Copy link
Collaborator

schmikei commented Jun 24, 2022

Third party test passed, Ops Agent Upgrade failed because of

=== CONT  TestUpgradeOpsAgent/windows-2019
    ops_agent_test.go:1693: WaitForMetric(metric=agent.googleapis.com/cpu/utilization, extraFilters=[]) failed: exhausted retries
--- FAIL: TestUpgradeOpsAgent (0.00s)
    --- PASS: TestUpgradeOpsAgent/windows-2012-r2 (750.55s)
    --- FAIL: TestUpgradeOpsAgent/windows-2019 (1270.42s)

@qingling128 @ridwanmsharif I don't believe this is a blocker, but do you have any thoughts?

@qingling128 qingling128 merged commit e61e736 into GoogleCloudPlatform:master Jun 24, 2022
@schmikei schmikei mentioned this pull request Jun 24, 2022
Merged
@qingling128
Copy link
Contributor

qingling128 commented Jun 27, 2022

Third party test passed, Ops Agent Upgrade failed because of

=== CONT  TestUpgradeOpsAgent/windows-2019
    ops_agent_test.go:1693: WaitForMetric(metric=agent.googleapis.com/cpu/utilization, extraFilters=[]) failed: exhausted retries
--- FAIL: TestUpgradeOpsAgent (0.00s)
    --- PASS: TestUpgradeOpsAgent/windows-2012-r2 (750.55s)
    --- FAIL: TestUpgradeOpsAgent/windows-2019 (1270.42s)

@qingling128 @ridwanmsharif I don't believe this is a blocker, but do you have any thoughts?

Forgot to mention: The TestUpgradeOpsAgent was a known issue that was fixed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingling128 qingling128 qingling128 left review comments

@jefferbrecht jefferbrecht jefferbrecht approved these changes

@sophieyfang sophieyfang sophieyfang approved these changes

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

@martijnvans martijnvans martijnvans approved these changes

Assignees

No one assigned

Labels

3rd-party-app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@StefanKurek @jefferbrecht @martijnvans @qingling128 @schmikei @sophieyfang @ridwanmsharif @kokoro-team @stackdriver-instrumentation-release