Add Apache Flink Metricsreceiver #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,10 +1,255 @@ | |||
| public_url: "https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/third-party/flink" | |||
There was a problem hiding this comment.
Can we get rid of the public_url? See #632 (comment)
It will be set by the post agent release job that will run
sophieyfang
reviewed
Jun 27, 2022
| @@ -1,10 +1,254 @@ | |||
| public_url: "https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/third-party/flink" | |||
There was a problem hiding this comment.
public_url was already cut inside branch 2.17.0 so removing it from the master branch doesn't really help but causes more confusion in the release script..
How it shall work:
For any new integrations, any manual PR created by non-machine shall not set/unset/modify public_url or minimum_supported_agent_version. Our jobs, e.g.
will set those two fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flink metrics receiver. This builds on #632