Skip to content

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Jun 9, 2022

This brings in a few CLs from the internal copy:

  1. a CL fixing some artifact finding code for windows.
  2. a CL removing the need for SCRIPTS_DIR for collectd_third_party_apps_test
  3. a CL fetching winrm.par from GCS instead of from $KOKORO_BLAZE_DIR

This script is currently unused so this PR has no actual effect.

This brings in a CL fixing some artifact finding code for windows. This script is currently unused so this PR has no actual effect.
@martijnvans martijnvans changed the title Testing: Bring in a CL to go_test.sh Testing: update how go_test.sh finds artifacts Jun 9, 2022
@martijnvans martijnvans requested review from a team and igorpeshansky and removed request for a team June 10, 2022 15:41
@martijnvans martijnvans changed the title Testing: update how go_test.sh finds artifacts Testing: update go_test.sh with changes to internal copy Jul 7, 2022
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit — please fix and merge.

LGTM :shipit:

@martijnvans martijnvans merged commit 5d04051 into master Jul 7, 2022
@martijnvans martijnvans deleted the martijnvans-windows-artifact-hunting branch July 7, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants