Skip to content

apps/rabbitmq: Add warning severity and fix time format regex #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 12, 2022
Merged

apps/rabbitmq: Add warning severity and fix time format regex #706

merged 9 commits into from
Jul 12, 2022

Conversation

@schmikei
Copy link
Collaborator

@schmikei schmikei commented Jun 29, 2022 •
edited
Loading

We were getting some errors in the logging-module logs concerning an invalid timestamp format and according to

image

Was able to validate changes on a GCE VM

Before:

[2022/06/29 15:27:28] [error] [parser] cannot parse '2022-06-29 15:27:26.103510+00:00' after %L
[2022/06/29 15:27:28] [ warn] [parser:rabbitmq.rabbitmq.rabbitmq] invalid time format %Y-%m-%d %H:%M:%S.%L+%Z for '2022-06-29 15:27:26.103510+00:00'

Afterwards the error log does not show up in logging-module.log

Also added a mapping for the warning severity:

Before:

jsonPayload: {
message: "Failed to add user 'otelu6': the user already exists"
process_id: "0.1219.0"
severity: "warning"
}

@schmikei schmikei added 3rd-party-app kokoro:force-run Forces kokoro to run integration tests on a CL labels Jun 29, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 29, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@schmikei schmikei marked this pull request as ready for review June 30, 2022 19:07
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 30, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 1, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 1, 2022
@schmikei
Copy link
Collaborator Author

schmikei commented Jul 1, 2022

Kokoro failures are unrelated

<failure message="Failed" type="">
third_party_apps_test.go:582: Test logs: https://console.cloud.google.com/storage/browser/ops-agents-public-buckets-test-logs/prod/stackdriver_agents/testing/consumer/third_party_apps/test/sles15/572/20220701-061725/logs/TestThirdPartyApps_sles-15_hbase third_party_apps_test.go:595: Instance Log: https://console.cloud.google.com/logs/viewer?resource=gce_instance%2Finstance_id%2F2585725234817747588&project=stackdriver-test-143416
</failure>

@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 6, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 6, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 8, 2022
@schmikei schmikei requested a review from ridwanmsharif July 8, 2022 15:39
ridwanmsharif
ridwanmsharif approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the PR title to something like:

apps/rabbitmq: add warning severity and fix time format regex since the release notes use the PR titles.

@schmikei schmikei changed the title RabbitMQ Logging: Small Regex Parser Fix apps/rabbitmq: Add warning severity and fix time format regex Jul 8, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 11, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 11, 2022
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 12, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 12, 2022
@ridwanmsharif ridwanmsharif merged commit ad67eb2 into GoogleCloudPlatform:master Jul 12, 2022
@schmikei schmikei deleted the rabbitmq-timestamp-rgex branch July 12, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

3rd-party-app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmikei @ridwanmsharif @stackdriver-instrumentation-release