Extended core metrics tests #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored AssertMetrics and assertMetricsLabel into common.go Added expected metrics yaml to integration_test/agent_metrics
sophieyfang
reviewed
Jul 7, 2022
… ExpectedMetric.Platform. Refactored osFolder() into gce_testing.go and renamed it to PlatformKind() Removed getExcludedPlatform()
Added representative metric to agent metrics Added omitempty to: ExpectedMetric.Labels, ExpectedMetric.Optional, ExpectedMetric.Representative Refactored testDefaultMetrics to use representative metric from metadata.yaml
….com/agent/request_count to metadata.yaml
…to avi-levy-extend-core-metrics
sophieyfang
reviewed
Jul 11, 2022
sophieyfang
reviewed
Jul 11, 2022
sophieyfang
reviewed
Jul 11, 2022
…count, swap/percent_used to metadata.yaml
sophieyfang
approved these changes
Jul 12, 2022
Fixed comments Optimized agent metrics testing to skip optional metrics.
…to avi-levy-extend-core-metrics
…to avi-levy-extend-core-metrics
# Conflicts: # integration_test/gce/gce_testing.go # integration_test/third_party_apps_test.go
Fixed comments and agent_metrics/metadata.yaml according to comments suggestions
martijnvans
added a commit
that referenced
this pull request
Jul 25, 2022
#719 changed the label matching to be a full match instead of a partial match, and that caused mysql tests to fail with `workload.googleapis.com/mysql.double_writes: error: label value does not match pattern. label=kind, pattern=writes|written, value=pages_written` errors
martijnvans
added a commit
that referenced
this pull request
Jul 25, 2022
#719 changed the label matching to be a full match instead of a partial match, and that caused mysql tests to fail with `workload.googleapis.com/mysql.double_writes: error: label value does not match pattern. label=kind, pattern=writes|written, value=pages_written` errors
9 tasks
martijnvans
added a commit
that referenced
this pull request
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended testing coverage of core metrics tests to include
value_type,kind,monitored_resourceandlabelsRefactored AssertMetrics and assertMetricsLabel into common.go
Added expected metrics yaml to integration_test/agent_metrics
http://b/230790404