Add mongodb enhancements #777
Conversation
| monitored_resource: gce_instance | ||
| labels: | ||
| database: .* | ||
| - type: workload.googleapis.com/mongodb.extent.count |
There was a problem hiding this comment.
I don't see this metric in the scope doc, does it need to be added there?
There was a problem hiding this comment.
Yeah, this should not be in this enhancements PR. It is in the scope doc but got left out of the original implementation. extent.count can only be used for mongodb version <= 4.2 and if the storage engine is MMAPv1. The default storage engine as of starting with 3.2 is the Wired Tiger. Updated.
| kind: CUMULATIVE | ||
| monitored_resource: gce_instance | ||
| labels: | ||
| operation: .* |
There was a problem hiding this comment.
This can be more strict right? (insert | query | update | delete | getmore | command) is what the scope doc says
|
Sure, mongodb enhancements got added in when the operations collector upgraded to 0.57.2. The Otel release v0.57.2 with this issue and this otel pr. I also rebuilt the docker image and tested on a vm to confirm that I am receiving the newest metrics. |
|
I noticed the operations collector just got updated with go 1.18 update. So I can updated submodule opentelemetry-operations-collector to that 1.18. I ran a test pr with kokoro on latest otel version to confirm there were no new breaking changes being introduced. |
I would advise not doing this for this current PR as it's not necessary. The postgres updates @schmikei is working on will require an operations collector update that will pull in the 1.18 update. @ridwanmsharif is this ok with you? |
|
Yup agreed with @cpheps, merging this as in now. Thanks for the explanation |
This PR adds the enhanced otel mongodb metrics