Skip to content

Rename makefile, improve tooling #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2022
Merged

Rename makefile, improve tooling #815

merged 5 commits into from
Sep 6, 2022

Conversation

@braydonk
Copy link
Contributor

@braydonk braydonk commented Aug 26, 2022

Description

Added yamlfmt tool for yaml formatting, addlicense for license header
checks, and some helpful precommit make targets using the new tools.

Related issue

b/238471196

How has this been tested?

make -f tasks.mak precommit: https://pastebin.com/uxKg1XF3
make -f tasks.mak addlicense: The results are part of the changes in this PR
make -f tasks.mak test_confgenerator_update: The results are part of the changes in this PR

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@braydonk braydonk requested review from a team and qingling128 and removed request for a team August 26, 2022 16:56
@braydonk
Copy link
Contributor Author

braydonk commented Aug 26, 2022

PR_Presubmit is going to fail here because it thinks I changed the supported agent version, but it's only an indentation change so it's fine to ignore.

qingling128
qingling128 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingling128
Copy link
Contributor

qingling128 commented Sep 6, 2022

LGTM

@braydonk
Rename makefile, improve tooling
3d216c0 
Added yamlfmt tool for yaml formatting, addlicense for license header
checks, and some helpful precommit make targets using the new tools.

more makefile stuff
@braydonk
update goldens and add license headers to new files
59e2ea3
@braydonk
remove yamlfmt until windows bug is fixed
00a2e98
@braydonk
added documentation for makefile
2bb1c6a
@braydonk
add missing license header
e3d44a9
@braydonk braydonk merged commit 32d7597 into master Sep 6, 2022
@igorpeshansky igorpeshansky deleted the braydonk-yamlfmt branch July 10, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingling128 qingling128 qingling128 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@braydonk @qingling128