Skip to content

Grab labels of pull request #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 1, 2022
Merged

Grab labels of pull request #818

merged 11 commits into from
Sep 1, 2022

Conversation

@avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Aug 26, 2022 •
edited
Loading

Description

Added a script that gets the up to date labels of a PR.

Related issue

b/243975669

How has this been tested?

Tested through git commits and pushes to this PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@avilevy18 avilevy18 added release and removed release labels Aug 26, 2022
@avilevy18 avilevy18 force-pushed the avilevy-labels-presubmit-test branch from 48c6fc5 to b3f7e3a Compare August 29, 2022 14:45
@avilevy18 avilevy18 changed the title Testing presubmit check for minimum_supported_agent_version Grab labels of pull request Aug 29, 2022
@avilevy18 avilevy18 marked this pull request as ready for review August 29, 2022 14:51
@avilevy18 avilevy18 requested a review from braydonk August 29, 2022 17:51
braydonk
braydonk reviewed Aug 31, 2022
View reviewed changes
@avilevy18
Addressed comments
8d1c90b 
Added Testing
@avilevy18 avilevy18 requested a review from braydonk August 31, 2022 19:35
@avilevy18 avilevy18 removed the release label Sep 1, 2022
braydonk
braydonk approved these changes Sep 1, 2022
View reviewed changes
@avilevy18 avilevy18 removed the release label Sep 1, 2022
braydonk
braydonk approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nitpick comments, otherwise looks great!

@avilevy18 avilevy18 merged commit ce23da8 into master Sep 1, 2022
@igorpeshansky igorpeshansky deleted the avilevy-labels-presubmit-test branch July 10, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braydonk braydonk braydonk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avilevy18 @braydonk