kokoro: install go 1.19 for tests #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot that this needed to be set for tests as well.
franciscovalentecastro
approved these changes
Sep 8, 2022
|
|
||
| # Download and install a newer version of go. | ||
| wget --no-verbose --output-document=/dev/stdout https://golang.org/dl/go1.17.linux-amd64.tar.gz | \ | ||
| wget --no-verbose --output-document=/dev/stdout https://golang.org/dl/go${GO_VERSION}.linux-amd64.tar.gz | \ |
There was a problem hiding this comment.
Is this the only place needed to update the Go version ?
There was a problem hiding this comment.
It was here and in the compat flag. The rest of the updates have been done already, I just missed this spot when I did it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Go version update missed that Go is running on 1.17 still in the integration tests. This PR updates that, introducing a variable for the next time this occurs.
Related issue
b/245751121
How has this been tested?
I'm using GitHub Actions to test it.
Checklist: