Skip to content

Use golden package in integration metadata test #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2022
Merged

Use golden package in integration metadata test #857

merged 2 commits into from
Sep 16, 2022

Conversation

@avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Sep 16, 2022

Description

Refactoring integration metadata tests to use the golden package.

Related issue

b/243948148

How has this been tested?

Integration tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@avilevy18 avilevy18 marked this pull request as ready for review September 16, 2022 19:07
@avilevy18 avilevy18 requested a review from braydonk September 16, 2022 19:07
@avilevy18 avilevy18 merged commit 314cbf3 into master Sep 16, 2022
@igorpeshansky igorpeshansky deleted the avilevy-golden-integration-metadata-test branch July 10, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braydonk braydonk braydonk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avilevy18 @braydonk