-
Notifications
You must be signed in to change notification settings - Fork 77
google-cloud-ops-agent-diagnostics service [Windows and Linux] #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4017d41 to
d7326dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responding to comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressing current comments.
|
Current status:
|
|
@qingling128 Adding elements to the current status update :
|
184a1d0 to
b1b3756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one comment that I forgot to send before, but otherwise LGTM!
Description
The changes presented implement a new binary in the folder
cmd/google_cloud_ops_agent_diagnosticsthat will run after thegoogle_cloud_ops_agent_enginebinary successfully generates and validates the required configurations forfluent-bitandotelopscol. This binary will run as a service, in Windows and Linux, along side the execution offluent-bitandotelopscol.The purpose of the
google-cloud-ops-agent-diagnosticsservice is to have a place to run diagnostics checks and actions during the execution of the Ops Agent. A non exhaustive list of this are :agent.googleapis.com/agent/ops_agent/enabled_receivers(Implemented in this PR)agent.googleapis.com/agent/ops_agent/feature_tracking(Future Work)Related issue
b/232815588 | b/245344014
How has this been tested?
TestDiagnosticsCrashRestartto verify the diagnostics service restarts after manually stopping (pkill) the binary.agent.googleapis.com/agent/ops_agent/enabled_receiversto the expected metrics verified by theTestDefaultMetricsNoProxytest.diagnosticsLivenessCheckerto theopsAgentLivenessChecker. It can't be done in the same PR since it's used inTestUpgradeOpsAgentwhich compares to a previous version that doesn't have the diagnostics service.TestEnabledReceiversDefaultConfigunit test to verify the count of receivers in the default configurations is what we expect.Windows 2019
Debian 10
Checklist: