Skip to content

Install varnish on centos7 #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

Install varnish on centos7 #874

merged 2 commits into from
Sep 27, 2022

Conversation

@dehaansa
Copy link
Contributor

@dehaansa dehaansa commented Sep 27, 2022

Description

There's an issue installing varnish & nginx on centos7, this resolves the issue using the recommended installation instructions here.

How has this been tested?

Tested that it successfully installed on a centos7 gcp image.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@dehaansa dehaansa added the kokoro:force-run Forces kokoro to run integration tests on a CL label Sep 27, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Sep 27, 2022
jkschulz
jkschulz reviewed Sep 27, 2022
View reviewed changes
integration_test/third_party_apps_data/applications/varnish/centos_rhel/install Outdated
EOF
fi

# Centos Stream / RHEL 8: Varnish 6.0.8
Copy link
Contributor

@jkschulz jkschulz Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think delete this comment, since it's misleading -- these commands run on more than just those versions, and it doesn't necessarily install that version of varnish

Copy link
Contributor Author

@dehaansa dehaansa Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, missed that cleanup after copying the existing code around.

@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Sep 27, 2022
@ridwanmsharif ridwanmsharif merged commit dcf9219 into GoogleCloudPlatform:master Sep 27, 2022
@dehaansa dehaansa deleted the centos7-varnish branch September 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jkschulz jkschulz jkschulz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kokoro:force-run Forces kokoro to run integration tests on a CL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dehaansa @jkschulz @ridwanmsharif @stackdriver-instrumentation-release