Skip to content

Testing: use ssh to connect to Windows instances #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 14, 2022
Merged

Testing: use ssh to connect to Windows instances #873

merged 8 commits into from
Oct 14, 2022

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Sep 26, 2022 •
edited
Loading

Description

This has several benefits, such as allowing ObservIQ members to be able to run Windows tests locally, and deletes our dependency on winrm.par. (No more need to specify WINRM_PAR_PATH!). It is also just really nice that we are doing things more or less the same for Linux and for Windows.

Related issue

b/209616302

How has this been tested?

Integration tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

jefferbrecht
jefferbrecht approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@jefferbrecht jefferbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 yay for being able to delete a ton of code

@martijnvans martijnvans changed the title Testing: use ssh to connect to Windows instances (new) Testing: use ssh to connect to Windows instances Oct 13, 2022
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 14, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 14, 2022
@martijnvans
Copy link
Contributor Author

martijnvans commented Oct 14, 2022

Windows failures look normal and a previous run was all green. Merging.

https://source.cloud.google.com/results/invocations/f45d336e-62ac-4300-abcb-af45864e7040/targets
https://source.cloud.google.com/results/invocations/ec0d6831-0030-4482-a172-c849874166fa/targets

@martijnvans martijnvans merged commit 2f8ccd9 into master Oct 14, 2022
@martijnvans martijnvans deleted the martijnvans-windows-ssh-new branch October 14, 2022 20:04
martijnvans added a commit that referenced this pull request Oct 19, 2022
@martijnvans
Revert "Testing: use ssh to connect to Windows instances (#873)"
a7e0ee5 
This reverts commit 2f8ccd9.
@martijnvans martijnvans mentioned this pull request Oct 19, 2022
Merged
martijnvans added a commit that referenced this pull request Oct 19, 2022
@martijnvans
Revert "Testing: use ssh to connect to Windows instances (#873)" (#915)
0835abc 
This reverts commit 2f8ccd9.
martijnvans added a commit that referenced this pull request Oct 20, 2022
@martijnvans
Revert "Revert "Testing: use ssh to connect to Windows instances (#873)…
677746e 
…" (#915)"

This reverts commit 0835abc.
@martijnvans martijnvans mentioned this pull request Oct 20, 2022
Merged
martijnvans added a commit that referenced this pull request Oct 21, 2022
@martijnvans
Restore "Testing: use ssh to connect to Windows instances" (#916)
fc4f0c5 
* Revert "Revert "Testing: use ssh to connect to Windows instances (#873)" (#915)"

This reverts commit 0835abc.

* added in fix for active directory ssh issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefferbrecht jefferbrecht jefferbrecht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martijnvans @jefferbrecht @stackdriver-instrumentation-release