Skip to content

Testing: fix hasMatchingLog to return the first match #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2022
Merged

Testing: fix hasMatchingLog to return the first match #896

merged 3 commits into from
Oct 10, 2022

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Oct 6, 2022

Description

Before this change, hasMatchingLog returns the last match instead of the first. This just fixes it to match its documented behavior.

Related issue

none, I just happened to notice this

How has this been tested?

Let's hope the integration tests pass haha

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans requested a review from avilevy18 October 6, 2022 21:51
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 7, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 7, 2022
@martijnvans martijnvans merged commit 7cf7426 into master Oct 10, 2022
@martijnvans martijnvans deleted the martijnvans-hasMatchingLog-first-match branch May 30, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avilevy18 avilevy18 avilevy18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martijnvans @avilevy18 @stackdriver-instrumentation-release