Skip to content

Running all 3rd party integration tests when a submodule is changed #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 25, 2022
Merged

Running all 3rd party integration tests when a submodule is changed #908

merged 7 commits into from
Oct 25, 2022

Conversation

@rafaelwestphal
Copy link
Contributor

@rafaelwestphal rafaelwestphal commented Oct 17, 2022 •
edited
Loading

Description

Integration tests should not be skipped when a submodule is upgraded. Enforcing that any changes to submodule/* folder will trigger the integration tests.

Related issue

How has this been tested?

I added a submodule change and verified that the tests were scheduled. Then i reverted the change.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@rafaelwestphal
Running all 3rd party integration tests when a submodule is changed
fd08c3f 
Integration tests should not be skipped when a submodule is upgraded.
Enforcing that any changes to submodule/* folder will trigger the
integration tests.
@rafaelwestphal
Temporarily changing fluentbit version to test
3cdde96
@rafaelwestphal
Reverting submodule update
b4a25ee
@rafaelwestphal rafaelwestphal marked this pull request as ready for review October 18, 2022 17:48
@jefferbrecht
Copy link
Member

jefferbrecht commented Oct 18, 2022

LGTM 👍

WDYT about also re-running the 3p tests if third_party_apps_test.go is modified?

@rafaelwestphal rafaelwestphal added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 18, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 18, 2022
@rafaelwestphal rafaelwestphal added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 19, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 19, 2022
@rafaelwestphal
Copy link
Contributor Author

rafaelwestphal commented Oct 19, 2022 •
edited
Loading

LGTM 👍

WDYT about also re-running the 3p tests if third_party_apps_test.go is modified?

I thought about this, but didn't come up with a critical scenario where this would be an issue. I think if third_party_apps_test.go gets modified it doesn't necessarily needs all tests to be run? That being said, i don't usually touch third party apps.

martijnvans
martijnvans reviewed Oct 19, 2022
View reviewed changes
@martijnvans martijnvans mentioned this pull request Oct 25, 2022
Merged
9 tasks
@martijnvans
Copy link
Contributor

martijnvans commented Oct 25, 2022

test failures are unrelated, and the still-running windows tests passed on a previous snapshot. merging.

@martijnvans martijnvans merged commit 38e3406 into master Oct 25, 2022
@martijnvans martijnvans deleted the westphalrafael-run-integration-tests-on-submodule-update branch October 25, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvans martijnvans martijnvans approved these changes

@jefferbrecht jefferbrecht jefferbrecht approved these changes

@stati0n stati0n Awaiting requested review from stati0n

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rafaelwestphal @jefferbrecht @martijnvans @stackdriver-instrumentation-release