Skip to content

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Oct 31, 2022

Description

Instead of using the --cache-to flag, which requires some gymnastics and doesn't seem to be git pull-able, let's just do a git push and use that for our cached image. It seems to work great in my testing, even getting cache hits for some of the layers but not all when appropriate. This should enable us to use kokoro's prefetching feature too.

Dropping --cache-to also means we don't need to use docker-container or buildx.

Related issue

b/255601283

How has this been tested?

I ran a few similar builds, and got partial cache hits on https://source.cloud.google.com/results/invocations/91180c6c-d031-4ff2-ad09-1df2a731e8f9/targets, and full cache hits on https://source.cloud.google.com/results/invocations/38e87531-adde-46c6-ba2d-a19f4c9dfe3a/targets.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 31, 2022
@martijnvans martijnvans removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Oct 31, 2022
@martijnvans martijnvans requested a review from Subbarker November 1, 2022 15:10
@martijnvans martijnvans merged commit 0c56e70 into master Nov 1, 2022
@martijnvans martijnvans deleted the martijnvans-docker-switcheroo branch November 1, 2022 18:42
@martijnvans martijnvans mentioned this pull request Jan 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants