Skip to content

Synchronize behavior and tests across Linux and Windows. #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2021
Merged

Synchronize behavior and tests across Linux and Windows. #94

merged 3 commits into from
Jun 10, 2021

Conversation

@igorpeshansky
Copy link
Contributor

@igorpeshansky igorpeshansky commented Jun 9, 2021

Also fix typos and inconsistencies in confgenerator test directory names.

@igorpeshansky igorpeshansky requested a review from qingling128 June 9, 2021 20:35
@igorpeshansky igorpeshansky mentioned this pull request Jun 9, 2021
Merged
qingling128
qingling128 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpeshansky igorpeshansky merged commit 7b0b8cb into master Jun 10, 2021
@igorpeshansky igorpeshansky deleted the igorpeshansky-confgenerator-cleanup branch June 10, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingling128 qingling128 qingling128 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorpeshansky @qingling128