Skip to content

Internal: use docker-credential-gcr on Linux too #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2022
Merged

Internal: use docker-credential-gcr on Linux too #965

merged 5 commits into from
Nov 21, 2022

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Nov 11, 2022 •
edited
Loading

Description

This is just like #964, but for Linux instead of Windows. All the same reasons for doing it still apply.

Related issue

b/255601283

How has this been tested?

automated tests.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans
Copy link
Contributor Author

martijnvans commented Nov 16, 2022

The only failure is an unrelated flake (Windows).

@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 16, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 16, 2022
@martijnvans martijnvans merged commit 0fb7bc5 into master Nov 21, 2022
@martijnvans martijnvans deleted the martijnvans-linux-docker-credentials branch November 21, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsmatulis hsmatulis Awaiting requested review from hsmatulis

1 more reviewer

@Subbarker Subbarker Subbarker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martijnvans @Subbarker @stackdriver-instrumentation-release