Skip to content

Testing: Install erlang differently for rabbitmq #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2022
Merged

Testing: Install erlang differently for rabbitmq #989

merged 2 commits into from
Nov 18, 2022

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Nov 17, 2022 •
edited
Loading

Description

This technique was taken from https://www.rabbitmq.com/install-rpm.html#package-cloud.

This fixes issues we're seeing at head that look like:

+ sudo yum -y install rabbitmq-server
        Last metadata expiration check: 0:00:01 ago on Wed Nov 16 18:39:45 2022.
        Error:
         Problem: cannot install the best candidate for the job
          - nothing provides erlang >= 25.0 needed by rabbitmq-server-3.11.3-1.el8.noarch

(https://source.cloud.google.com/results/invocations/2ecf0d78-49f1-4ed1-aa09-62182f7a770f/targets)

Related issue

b/259553369

How has this been tested?

rocky-linux-8 tests fail before ths PR and pass after this PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans changed the title try a different way of installing erlang for rabbitmq Install erlang differently for rabbitmq Nov 17, 2022
@martijnvans martijnvans requested a review from Mrod1598 November 17, 2022 20:06
@martijnvans martijnvans changed the title Install erlang differently for rabbitmq Testing: Install erlang differently for rabbitmq Nov 17, 2022
@martijnvans
Copy link
Contributor Author

martijnvans commented Nov 18, 2022

rabbitmq ppassed on all platforms. Merging PR despite a few unrelated failures.

@martijnvans martijnvans requested review from a team and LujieDuan and removed request for a team and Mrod1598 November 18, 2022 15:44
LujieDuan
LujieDuan approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@LujieDuan LujieDuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martijnvans martijnvans merged commit 7f2fa49 into master Nov 18, 2022
@martijnvans martijnvans deleted the martijnvans-try-different-erlang-rabbitmq branch November 18, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LujieDuan LujieDuan LujieDuan approved these changes

+1 more reviewer

@cpheps cpheps cpheps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martijnvans @LujieDuan @cpheps