Skip to content

Change receiver feature gate to a list #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2022
Merged

Change receiver feature gate to a list #996

merged 4 commits into from
Nov 21, 2022

Conversation

@jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Nov 21, 2022

Description

This is in preparation for the OTLP receiver; we'd like to avoid having to define a new env variable for each feature gate.

Related issue

b/239598894

How has this been tested?

Unit tests pass, will let integration tests run in PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

ridwanmsharif
ridwanmsharif approved these changes Nov 21, 2022
View reviewed changes
@jefferbrecht
Change receiver feature gate to a list
c1af65c 
This is in preparation for the OTLP receiver; we'd like to avoid having
to define a new env variable for each feature gate.
@jefferbrecht
Use more generic variable name
1e53650
@jefferbrecht
Rename feature tracking files
4bd8336
@jefferbrecht
Split IsExperimentalFeatureEnabled to new file
9ce07a3
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-refactor-receiver-gate branch from f24845c to 9ce07a3 Compare November 21, 2022 18:46
@jefferbrecht jefferbrecht merged commit ff240eb into master Nov 21, 2022
@jefferbrecht
Copy link
Member Author

jefferbrecht commented Nov 21, 2022

All tests passed in a prior run except for Bionic which was an unrelated failure; merging.

@jefferbrecht jefferbrecht deleted the jefferbrecht-refactor-receiver-gate branch November 21, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferbrecht @ridwanmsharif