fix production spec path used in bounding box computation#30
Merged
Conversation
andrelimapedro
approved these changes
Apr 5, 2022
andrelimapedro
approved these changes
Apr 5, 2022
andrelimapedro
approved these changes
Apr 5, 2022
Pull Request Test Coverage Report for Build 2096515000
💛 - Coveralls |
thiagomourahp
approved these changes
Apr 5, 2022
Collaborator
|
Related to #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue causing the library not to find models when computing the bounding box. Models were not found when a resource from an external model was referenced in a root model, because the wrong path was hardcoded when looking for the external resource.
Initially I thought we'd have to change this other path too, but after adding unit tests, this doesn't seem necessary.