Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Homebrew/BrewUI
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.2
Choose a base ref
...
head repository: Homebrew/BrewUI
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.3
Choose a head ref
  • 17 commits
  • 97 files changed
  • 7 contributors

Commits on Sep 16, 2026

  1. Drop the leading icon from package list rows

    Every installed row drew the same cube.box.fill and every Discover row
    the same shippingbox.fill, in a 36pt stroked circle tinted by package
    kind. The glyph never varied and the tint duplicated the FORMULA/CASK
    pill beside it, so the leading column only pushed the name off the
    list's left edge and gave each row a second alignment axis to parse.
    
    With it gone the row states its rank typographically instead: the name
    takes a new brewBodyEmphasized token (.body semibold, same 13pt), above
    the brewCallout description and brewCaption version line.
    
    Titles are lineLimit(1) — SwiftUI was otherwise truncating one long name
    and wrapping the next depending on the pills beside it, leaving the kind
    pill floating against the second line on some rows. The untruncated name
    stays on the row's accessibility label and in the detail pane.
    
    The kind pill's chrome picks up brewHiddenWhenRedacted(), which the
    icon's circle was the only caller of; .redacted leaves Shape alone, so
    the pill's fill and stroke stayed crisp around redacted skeleton rows.
    bevanjkay committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    68b2e07 View commit details
    Browse the repository at this point in the history
  2. Lint the app in CI, and fix stale Brew/ paths

    `swift_quality.yml` ran BrewUILint over `find Brew Sources`. There is no
    `Brew` directory, so `find` errored and matched only `Sources`, silently
    skipping the 17 Swift files in `Homebrew/`. `scripts/pre-commit` already
    uses `find Homebrew Sources`; CI now matches it.
    
    The same rename left `Brew/` in the docs: two dead links in CONVENTIONS.md,
    and a `Brew/**/*.swift` glob in design-system.mdc that never matches, so the
    Cursor design-system rule never applied to any file.
    SurefireStudios
    SurefireStudios committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    7233d4f View commit details
    Browse the repository at this point in the history
  3. Run Swift Quality when its own workflow changes

    The paths filter did not list swift_quality.yml, so edits to the lint and
    format job were never exercised by that job. Adding it means this change to
    the BrewUILint glob is validated by the run it affects.
    SurefireStudios
    SurefireStudios committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    45d2a0a View commit details
    Browse the repository at this point in the history
  4. Include Homebrew sbin in the shell PATH

    - Avoid false Doctor warnings when formulae install into `sbin`.
    - Derive the path from `brew` and cover command lookup in tests.
    MikeMcQuaid committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    0a38d5f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #211 from Homebrew/pkg_hierarchy_fix

    Drop the leading icon from package list rows
    graeme authored Sep 16, 2026
    Configuration menu
    Copy the full SHA
    a6bf723 View commit details
    Browse the repository at this point in the history
  6. Fix the remaining stale Brew paths in lint, CI and docs

    `.swiftlint.yml` had `included: Brew`, so `swiftlint lint --strict` skipped
    the app targets entirely; it now lists `Homebrew` and `HomebrewUpgradeHelper`.
    
    `pr_build_test.yml` filtered on `Brew/**` and `Brew.entitlements`, so an
    app-only change could skip Build and Test. No entitlements file exists
    anywhere in the tree, so that entry is dropped rather than repointed.
    
    BrewUILint's glob reached `Homebrew` but not `HomebrewUpgradeHelper`, leaving
    2 files unlinted; CI, `scripts/pre-commit` and AGENTS.md now agree on
    `find Homebrew HomebrewUpgradeHelper Sources`.
    
    CONVENTIONS.md and two Cursor rules pointed at `Brew/Models/HomebrewPackageReference.swift`
    and `Brew/PreviewSupport/AppPreviewSupport.swift`, neither of which exists under
    any prefix; they now point at `Sources/BrewCore/Models/HomebrewPackageID.swift`
    and `Sources/BrewRepositoryInterfaces/PreviewSupport/PreviewSupport.swift`.
    SurefireStudios
    SurefireStudios committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    57f862f View commit details
    Browse the repository at this point in the history
  7. Merge pull request #218 from Homebrew/homebrew_sbin_path

    Include Homebrew sbin in the shell PATH
    graeme authored Sep 16, 2026
    Configuration menu
    Copy the full SHA
    4a55f04 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2026

  1. Merge pull request #215 from SurefireStudios/fix/brewuilint-ci-path

    Lint the app in CI, and fix stale `Brew/` paths
    graeme authored Sep 17, 2026
    Configuration menu
    Copy the full SHA
    a04a9ea View commit details
    Browse the repository at this point in the history
  2. Restore the main window's remembered size

    SwiftUI autosaves a WindowGroup's frame under a key built from the root
    view's type name, modifier chain included. CrashReportSheetModifier was
    file-private, and a private type's context prints as "(unknown context
    at $addr)" where the address is the load address, which ASLR changes
    every launch. So each run saved its frame under a fresh key and none
    found the previous one. Making the type internal gives it a stable name.
    
    The default height also sat below the minimum since 8c083f5 raised the
    floor to 680, so a first launch was clamped rather than opening at the
    size asked for. 720 keeps the two in agreement.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    graeme and claude committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    bbb950d View commit details
    Browse the repository at this point in the history
  3. Move the UI-testing seams out of BrewApp

    Every -uiTesting fallthrough lived between init and body, so the
    composition root read as half test plumbing. They now sit in an
    extension under Homebrew/UITesting alongside the launch configuration
    they consume. Bodies are unchanged; the members drop private because a
    cross-file extension cannot reach it.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    graeme and claude committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    3f7b6f6 View commit details
    Browse the repository at this point in the history
  4. Consolidate documentation and agent guidance

    - Keep the project overview and development setup in `README.md`.
    - Put system design in `ARCHITECTURE.md` and detailed contributor and
      agent guidance in `AGENTS.md`; symlink `CLAUDE.md` to that source.
    - Remove duplicate rules, memory files and unused Jekyll tooling.
    MikeMcQuaid committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    08afc26 View commit details
    Browse the repository at this point in the history
  5. ARCHITECTURE: improve links.

    Co-authored-by: Graeme Arthur <2030310+graeme@users.noreply.github.com>
    MikeMcQuaid and graeme authored Sep 17, 2026
    Configuration menu
    Copy the full SHA
    02d7e82 View commit details
    Browse the repository at this point in the history
  6. Cover window size restoration with a UI test

    Resize, quit with Cmd-Q, relaunch, and expect the same size back. It
    fails against the private modifier and passes with the fix.
    
    The runner is sandboxed, so it cannot clear the app's defaults to get a
    predictable starting window. A new BREW_UITEST_RESET_WINDOW_STATE
    launch environment key asks the app to do it: both the NSWindow Frame
    and NSSplitView Subview Frames keys go, because a new window with no
    saved frame is sized to fit the split view's restored columns.
    
    The drag lives in an XCUIElement extension. A click exactly on the edge
    starts no resize; a few points inside the corner does. The window is
    shrunk rather than grown: a default-size window can always shrink
    towards the minimum, whereas growing needs screen room the 1024x768
    CI display does not have.
    
    Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    graeme and claude committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    f16f48e View commit details
    Browse the repository at this point in the history
  7. Merge pull request #221 from Homebrew/consolidate-documentation

    Consolidate documentation and agent guidance
    MikeMcQuaid authored Sep 17, 2026
    Configuration menu
    Copy the full SHA
    b9f5f36 View commit details
    Browse the repository at this point in the history
  8. Bump the github-actions group across 1 directory with 3 updates

    Bumps the github-actions group with 3 updates in the / directory: [Homebrew/actions/setup-homebrew](https://github.com/homebrew/actions), [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) and [Homebrew/actions/cache-homebrew-prefix](https://github.com/homebrew/actions).
    
    
    Updates `Homebrew/actions/setup-homebrew` from 2026.09.07.1 to 2026.09.13.1
    - [Release notes](https://github.com/homebrew/actions/releases)
    - [Changelog](https://github.com/Homebrew/actions/blob/main/release.test.mts)
    - [Commits](Homebrew/actions@f8d4222...1e34f2e)
    
    Updates `github/codeql-action/upload-sarif` from 4.37.9 to 4.38.0
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@cdf488f...b96794f)
    
    Updates `Homebrew/actions/cache-homebrew-prefix` from 2026.09.07.1 to 2026.09.13.1
    - [Release notes](https://github.com/homebrew/actions/releases)
    - [Changelog](https://github.com/Homebrew/actions/blob/main/release.test.mts)
    - [Commits](Homebrew/actions@f8d4222...1e34f2e)
    
    ---
    updated-dependencies:
    - dependency-name: Homebrew/actions/setup-homebrew
      dependency-version: 2026.09.13.1
      dependency-type: direct:production
      dependency-group: github-actions
    - dependency-name: github/codeql-action/upload-sarif
      dependency-version: 4.38.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-actions
    - dependency-name: Homebrew/actions/cache-homebrew-prefix
      dependency-version: 2026.09.13.1
      dependency-type: direct:production
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Sep 17, 2026
    Configuration menu
    Copy the full SHA
    d20b391 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #223 from Homebrew/dependabot/github_actions/githu…

    …b-actions-6ea0ec6221
    
    Bump the github-actions group across 1 directory with 3 updates
    MikeMcQuaid authored Sep 17, 2026
    Configuration menu
    Copy the full SHA
    7eede87 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #220 from Homebrew/fix-window-size

    Fix window size
    graeme authored Sep 17, 2026
    Configuration menu
    Copy the full SHA
    fbc6a43 View commit details
    Browse the repository at this point in the history
Loading