workflows/tests: typecheck core & cask taps#22013
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Homebrew’s CI typechecking to include official taps by allowing brew typecheck to accept multiple tap arguments and then invoking it for homebrew/core and homebrew/cask in the tap-syntax workflow.
Changes:
- Update
brew typecheckto pass multiple tap directories tosrb tc(instead of only the first tap). - Install the
typecheckBundler group in thetap-syntaxCI job. - Add a new CI step to run
brew typecheck homebrew/core homebrew/cask.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Library/Homebrew/dev-cmd/typecheck.rb |
Extends Sorbet invocation to include multiple tap directories. |
.github/workflows/tests.yml |
Adds a brew typecheck run for homebrew/core and homebrew/cask in CI and ensures needed gems are installed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhongRuoyu
approved these changes
Apr 14, 2026
Member
|
Makes sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can check for things like Homebrew/homebrew-core#277429.