Skip to content

numpy 2.4.0 #259569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrewTestBot merged 6 commits into from
Dec 21, 2025
Merged

numpy 2.4.0 #259569

BrewTestBot merged 6 commits into from
Dec 21, 2025
+46 −29

Conversation

@BrewTestBot
Copy link
Contributor

@BrewTestBot BrewTestBot commented Dec 20, 2025

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` meson Meson use is a significant feature of the PR or issue long dependent tests Set a long timeout for dependent testing labels Dec 20, 2025
@chenrui333 chenrui333 added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Dec 20, 2025
@chenrui333
Copy link
Member

chenrui333 commented Dec 21, 2025

needs numpy@2.3

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core alias labels Dec 21, 2025
@chenrui333 chenrui333 changed the title numpy 2.4.0 numpy 2.4.0 numpy@2.3 2.3.5 (new formula) Dec 21, 2025
@chenrui333 chenrui333 marked this pull request as draft December 21, 2025 02:48
@chenrui333 chenrui333 mentioned this pull request Dec 21, 2025
Closed
@branchv
Copy link
Member

branchv commented Dec 21, 2025

ImportError: Numba needs NumPy 2.3 or less. Got NumPy 2.4.

Unsure why numba pinned numpy with numba/numba@be9b583, the commit/PR doesn't explain at all. numba/numba#10263 asks for 2.4 support, I think rather than introducing a numpy@2.3 we should just try patching out that check (assuming there are no actual incompatibilities with 2.4)

@chenrui333
Copy link
Member

chenrui333 commented Dec 21, 2025

ImportError: Numba needs NumPy 2.3 or less. Got NumPy 2.4.

Unsure why numba pinned numpy with numba/numba@be9b583, the commit/PR doesn't explain at all. numba/numba#10263 asks for 2.4 support, I think rather than introducing a numpy@2.3 we should just try patching out that check (assuming there are no actual incompatibilities with 2.4)

yeah, I was thinking about that, that is why I raised the issue.

@chenrui333 chenrui333 mentioned this pull request Dec 21, 2025
Merged
@chenrui333
Copy link
Member

chenrui333 commented Dec 21, 2025

another way is to revert to use resource.

@branchv
Copy link
Member

branchv commented Dec 21, 2025

Yea if numba really does need numpy<2.4, let's just use resources for backgroundremover + openai-whisper

@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core alias labels Dec 21, 2025
@chenrui333
Copy link
Member

chenrui333 commented Dec 21, 2025

let's just go with the resource route, numba side might need more time working on the numpy 2.4 support.

@chenrui333 chenrui333 changed the title numpy 2.4.0 numpy@2.3 2.3.5 (new formula) numpy 2.4.0 Dec 21, 2025
@chenrui333 chenrui333 marked this pull request as ready for review December 21, 2025 03:44
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 21, 2025
@chenrui333
backgroundremover: update to use numpy resource
6d20000 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
openai-whisper: update to use numpy resource
75250d0 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Dec 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 21, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 21, 2025
Merged via the queue into main with commit 68879b4 Dec 21, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the bump-numpy-2.4.0 branch December 21, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iMichka iMichka iMichka approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing meson Meson use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BrewTestBot @chenrui333 @branchv @iMichka @daeho-ro