Fix Linux build issues#25
Merged
Merged
Conversation
n-marion
reviewed
Nov 18, 2024
91c9b50 to
4082405
Compare
04b3ccb to
0b3ac83
Compare
33cf782 to
43c2a05
Compare
Signed-off-by: Andreas Krebbel <krebbel@linux.ibm.com>
43c2a05 to
8e07a95
Compare
Signed-off-by: Andreas Krebbel <krebbel@linux.ibm.com>
80c0254 to
41b6f1f
Compare
Signed-off-by: Andreas Krebbel <krebbel@linux.ibm.com>
Signed-off-by: Andreas Krebbel <krebbel@linux.ibm.com>
41b6f1f to
235f0d7
Compare
Signed-off-by: Nicholas Marion <nmarion@us.ibm.com>
n-marion
approved these changes
Nov 22, 2024
n-marion
left a comment
Member
There was a problem hiding this comment.
Confirmed runs well on zOS and internal tests.
n-marion
added a commit
that referenced
this pull request
Nov 22, 2024
* Fix Linux build issues * Add missing prototypes to testsupport.h * Get rid of type-aliasing warning * Go down to z14 to support older distros * Resolve CPPCheck errors. --------- Signed-off-by: Andreas Krebbel <krebbel@linux.ibm.com> Co-authored-by: Nicholas Marion <nmarion@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of libzdnn does not build on Linux with recent GCCs (>=14). Unfortunately the data types of a few intrinsics changed in way which triggers compile errors when compiling without -flax-vector-conversions. Since using that option for building the entire library would probably paper over other potential errors as well, I rather went with a GCC version check for that particular macro. Clang was already using the GCC 14 intrinsics, so no change required here.
I've tried to keep the z/OS could unchanged, but could not test it. Please verify that it still works there. Thanks!