Skip to content

Conversation

@FeSens
Copy link

@FeSens FeSens commented Jun 6, 2022

Assert the inputs are the correct type. There is no way for the end-user to know the right input type only by reading the documentation; therefore, code should speak by itself, asserting the correct type.

@pronics2004 pronics2004 self-requested a review June 6, 2022 14:27
@pronics2004
Copy link
Member

Thanks @FeSens. This is helpful and can be temporary fix.

Looks like we should support the use of dataloader in the fit method for BNNRegression similar to BNNClassification. I have created an issue to track that #22.

You are welcome to take this on if you wish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants