[frontend] Moving the concept of store_submission into the Task Dispenser#851
Merged
Conversation
anthonygego
requested changes
Jul 27, 2022
| pass | ||
|
|
||
| @abstractmethod | ||
| def get_stored_submissions(self, taskid): |
Member
There was a problem hiding this comment.
As it is being modified, I think it would be more intuitive and readable for newcomers to rename stored_submissions to no_stored_submissions (no = number abbreviation).
| return submissionid, to_remove | ||
|
|
||
| def _delete_exceeding_submissions(self, username, task, max_submissions_bound=-1): | ||
| def _delete_exceeding_submissions(self, username, task, task_dispenser, max_submissions_bound=-1): |
Member
There was a problem hiding this comment.
Either there is a call to this function that has not been updated, either the max_submissions_bound argument is never used and removed from the signature.
| """ Returns the localized task dispenser name """ | ||
| return _("Table of contents") | ||
|
|
||
| def get_course_grade(self, username): |
Member
There was a problem hiding this comment.
Is this a duplicated piece of code ?
| else: | ||
| raise InvalidTocException( ("The weight value must be a numeric >= 0 for the task: " + str(taskid)) ) | ||
|
|
||
| self._store_submission = {} |
Member
There was a problem hiding this comment.
I guess this piece of code was taken from the edit task page code, but I don't see it removed from anywhere in the code in this PR.
| </div> | ||
| </div> | ||
| <div class="form-group row"> | ||
| <label for="groups" class="col-sm-2 control-label">{{_("Submission mode")}}</label> |
Member
There was a problem hiding this comment.
Not sure this should be removed from this PR.
Member
|
LGTM |
15 tasks
anthonygego
pushed a commit
that referenced
this pull request
Mar 19, 2025
anthonygego
pushed a commit
that referenced
this pull request
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.