Fix - removed indentation in tutorial#1027
Merged
Merged
Conversation
Contributor
|
You gave no explanation on what the problem was and how you fixed it. Please provide those in your PR description. Also provide proof there was a problem and that your changes are valid and do not cause more problems. |
Contributor
Author
|
Indeed I forgot to give context as I thought it was clear of the changes I did. I added what you asked and hope it is greatly structured. Thanks for the feedback, I tend to forgot to bring context. |
e53b0e2 to
9a6d192
Compare
anthonygego
pushed a commit
that referenced
this pull request
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to solve an issue related to the doc.
Looking at the tutorial of how to write an hello world exercise, it stated an example of the code to put in a template file to run the student code.
The problem is that the student code is inside the function and the funtion was called at the end of the function instead of being called after the function definition. This would result in not being able to run the student code but even by running the function it will be an infinite loop.
To solve this, I had to remove one indentation level as Python works with identation at the right level to call a function. By testing, the code was indeed showing nothing before the change and displayed "hello world" after changes.