Skip to content

make the response module public#89

Merged
eldesh merged 1 commit into
Idein:masterfrom
nyuichi:make-response-public
Apr 20, 2020
Merged

make the response module public#89
eldesh merged 1 commit into
Idein:masterfrom
nyuichi:make-response-public

Conversation

@nyuichi
Copy link
Copy Markdown
Contributor

@nyuichi nyuichi commented Apr 16, 2020

This PR makes the response module public.
Although data coming from /images/create is not reliable, checking the data is the only way to measure the progress of docker pull and thus considered useful.

@eldesh
Copy link
Copy Markdown
Collaborator

eldesh commented Apr 20, 2020

This feature relies on an undocumented API schema, but it can't be helped...
ref. https://stackoverflow.com/questions/19387501/how-to-handle-docker-api-images-create

@eldesh eldesh merged commit e4c792e into Idein:master Apr 20, 2020
@eldesh eldesh mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants