Fix rounded corner on the tray private button#2011
Merged
Conversation
The button used isTabsBarVisible to pick the rounded start background but that flag is true during normal browsing regardless of the tabs location. Use tabsButtonInTray so the button is only rounded when it is actually first in the row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing #2010 I noticed that the tray private browsing button gets a rounded bottom left corner when the maximum number of windows is open, even though the tabs button is still first in the row.
The rounded start background was picked based on
isTabsBarVisible, which is true during normal browsing regardless of the tabs location. The condition is nowtabsButtonInTray, so the button only becomes rounded when the tabs button is not in the tray.Screenshot:
