fix(merkle): align naming#1005
Merged
Merged
Conversation
4350d28 to
c6d6e4b
Compare
| for proof in proofs { | ||
| let encoded_proof = Base64(proof.proof.clone()); | ||
| validate_path(tx_root.0, &encoded_proof, proof.offset as u128).unwrap(); | ||
| validate_path(tx_root.0, &encoded_proof, proof.last_byte_index as u128).unwrap(); |
Member
There was a problem hiding this comment.
the 3rd arg here is called target_offset, but we're passing in last_byte_index - so which is it, an offset, or an index?
(I assume it's an index given your rename, if so, please rename the arg in the validate_path function)
c6d6e4b to
921b260
Compare
921b260 to
af8feff
Compare
JesseTheRobot
pushed a commit
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
Related Issue(s)
Please link to the issue(s) that will be closed with this PR.
Checklist
Additional Context
Add any other context about the pull request here.