feat: make cache service prune expired ingress proofs from the cache#1024
Merged
Conversation
…eat-prune-ingress-proof
# Conflicts: # crates/actors/src/mempool_service/ingress_proofs.rs
JesseTheRobot
requested changes
Nov 25, 2025
JesseTheRobot
left a comment
Member
There was a problem hiding this comment.
Overall looks good, but I have some concerns about some logic in the new compute_promotion_status function & I would love to see some tests for this (though we can defer for now given the time constraints)
| if !submit_txs_from_canonical.contains(&tx_header.id) { | ||
| let single_block = submit_tx_slice.iter().any(|h| h.id == tx_header.id); | ||
| if !single_block { | ||
| let previously_included = db |
Member
There was a problem hiding this comment.
tx headers are only inserted into the database when the block migrates - see the promotion validation logic used as part of block_validation
Contributor
Author
There was a problem hiding this comment.
After some discussions reverted back to the original logic
Co-authored-by: Jesse Cruz Wright <jesse.cruz.wright@gmail.com>
# Conflicts: # crates/actors/src/cache_service.rs
…al' into feat-prune-ingress-proofs-for-real
# Conflicts: # crates/actors/src/mempool_service/chunks.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds ingress proof cache pruning based on expired anchors
Related Issue(s)
Checklist
Additional Context