fix: build_current_commitment_snapshot_from_index uses block tree start#1022
Merged
Conversation
previously, build_current_commitment_snapshot_from_index would use the latest block index to inform itself of the latest epoch block. however, the block tree depth is normally before the latest block index entry, so this logic would skip out blocks.
JesseTheRobot
added a commit
that referenced
this pull request
Nov 24, 2025
…rt (#1022) * fix: build_current_commitment_snapshot_from_index uses block tree start previously, build_current_commitment_snapshot_from_index would use the latest block index to inform itself of the latest epoch block. however, the block tree depth is normally before the latest block index entry, so this logic would skip out blocks. * chore: fix formatting * feat: improve error observability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, build_current_commitment_snapshot_from_index would use the latest block index to inform itself of the latest epoch block. however, the block tree depth is normally before the latest block index entry, so this logic could skip out epoch blocks, which would cause the node to panic without recovery.
Describe the changes
A clear and concise description of what the bug fix, feature, or improvement is.
Related Issue(s)
Please link to the issue(s) that will be closed with this PR.
Checklist
Additional Context
Add any other context about the pull request here.