fix(mempool): add priority based eviction for pending chunk cache#1038
Merged
Conversation
| let tx_offset = chunk.tx_offset; | ||
|
|
||
| if let Some(chunks) = self.entries.get_mut(&data_root) { | ||
| chunks.put(tx_offset, chunk); |
Member
There was a problem hiding this comment.
can we add logging for evictions here?
JesseTheRobot
approved these changes
Dec 2, 2025
JesseTheRobot
left a comment
Member
There was a problem hiding this comment.
LGTM, feedback is nonblocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
Before:
Pending chunks cache used LRU eviction, allowing attackers to flood the cache with single-chunk entries and evict legitimate multi-chunk uploads.
After:
Cache evicts entries with the fewest chunks first, protecting multi-chunk uploads from single-chunk flooding attacks.
Changes
New Module:
pending_chunks.rsPriorityPendingChunksstruct with priority-based evictionmempool_service.rsLruCache<DataRoot, LruCache<...>>withPriorityPendingChunksput_chunk()method signature (removedpreheader_chunks_per_itemparameter)create_state()and test mock to use new typechunks.rsput_chunk()call siteRelated Issue(s)
Please link to the issue(s) that will be closed with this PR.
Checklist
Additional Context
Add any other context about the pull request here.