feat: custom serde serializer/deserializer impl#1043
Closed
JesseTheRobot wants to merge 1 commit into
Closed
Conversation
Adds a custom "canonical JSON" ser/des for use in our API The reason we need this is enforcing correct formatting with #[serde(with ...)] and #[serde(rename_all = "camelCase")] was error prone and oftentimes required duplicate structures to prevent these attributes from interfereing with other ser/des targets (i.e the toml config) NOTE: claude produced this version of the code, I still need to more thoroughly review it.
Member
Author
|
closing as merged into #1029 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a custom "canonical JSON" ser/des for use in our API The reason we need this is enforcing correct formatting with #[serde(with ...)] and #[serde(rename_all = "camelCase")] was error prone and oftentimes required duplicate structures to prevent these attributes from interfereing with other ser/des targets (i.e the toml config) NOTE: claude produced this version of the code, I still need to more thoroughly review it.
Describe the changes
A clear and concise description of what the bug fix, feature, or improvement is.
Related Issue(s)
Please link to the issue(s) that will be closed with this PR.
Checklist
Additional Context
Add any other context about the pull request here.