feat: better block cache for block bodies#1145
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds a sealed-block accessor to BlockTree, introduces a small recently-processed SealedBlock LRU cache in the block pool and updates removal semantics to record successful processing, and changes gossip data retrieval to check block pool → block tree → mempool reconstruction when assembling block bodies. Changes
Sequence Diagram(s)sequenceDiagram
participant Peer as Peer/Requestor
participant Gossip as GossipHandler
participant Pool as BlockPool
participant Tree as BlockTree
participant Mempool as Mempool
Peer->>Gossip: GET_DATA(block_hash)
Gossip->>Pool: get_cached_block_body(block_hash)
alt found in recently_processed / pool cache
Pool-->>Gossip: Arc<BlockBody>
Gossip-->>Peer: block body
else not in pool
Gossip->>Tree: get_sealed_block(block_hash)
alt found in BlockTree
Tree-->>Gossip: Arc<SealedBlock> (body)
Gossip-->>Peer: block body
else not in BlockTree
Gossip->>Mempool: reconstruct body from header / mempool DB
alt reconstruction success
Mempool-->>Gossip: Arc<BlockBody>
Gossip-->>Peer: block body
else failure
Mempool-->>Gossip: None / error
Gossip-->>Peer: None / error
end
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
# Conflicts: # crates/p2p/src/block_pool.rs
3 tasks
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR improves the block body pipeline to use stored block bodies instead of assembling them as much as possible
Related Issue(s)
Checklist
Additional Context
Summary by CodeRabbit