chore: claude.md and a skill for writing integration tests#1141
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughTwo documentation files were added/expanded: a new integration-testing skill guide for Irys at .claude/skills/writing-integration-tests/SKILL.md, and an expanded CLAUDE.md with build/development commands, architecture overview, and testing/git conventions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@CLAUDE.md`:
- Around line 16-20: The fenced code block after the "Run a single test:" line
in CLAUDE.md is missing a blank line; insert a single blank line between the
paragraph "Run a single test:" and the opening triple-backticks (```) so the
code block renders correctly across Markdown parsers, leaving the existing
contents unchanged.
- Around line 46-55: Add a language identifier to the fenced code block under
the "### Crate Dependency Layers" heading so markdown linters and syntax
highlighters treat it as plain text; locate the triple-backtick block that
contains the Foundation/Domain/Services/etc. lines and change the opening fence
from ``` to ```text (or ```plaintext) to explicitly specify the language.
| Run a single test: | ||
| ```sh | ||
| cargo nextest run -p irys-actors test_name | ||
| cargo test -p irys-actors test_name # alternative without nextest | ||
| ``` |
There was a problem hiding this comment.
Add blank line before fenced code block.
Markdown best practice requires blank lines around fenced code blocks for consistent rendering across different parsers.
📝 Proposed fix
Run a single test:
+
```sh
cargo nextest run -p irys-actors test_name
cargo test -p irys-actors test_name # alternative without nextest🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 17-17: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🤖 Prompt for AI Agents
In `@CLAUDE.md` around lines 16 - 20, The fenced code block after the "Run a
single test:" line in CLAUDE.md is missing a blank line; insert a single blank
line between the paragraph "Run a single test:" and the opening triple-backticks
(```) so the code block renders correctly across Markdown parsers, leaving the
existing contents unchanged.
| ### Crate Dependency Layers | ||
|
|
||
| ``` | ||
| Foundation: irys-types, irys-config, irys-database | ||
| Domain: irys-domain (BlockTree, BlockIndex, StorageModule, SupplyState) | ||
| Services: irys-actors (all services), irys-p2p, irys-api-server (actix-web) | ||
| Integration: irys-reth + irys-reth-node-bridge (EVM via Reth fork) | ||
| Subsystems: irys-packing, irys-packing-worker, irys-storage, irys-vdf | ||
| Utilities: irys-utils, irys-testing-utils, irys-cli, xtask | ||
| ``` |
There was a problem hiding this comment.
Specify language for fenced code block.
The dependency diagram code block should specify a language identifier (e.g., text or plaintext) for proper syntax highlighting and markdown linting compliance.
📝 Proposed fix
### Crate Dependency Layers
-```
+```text
Foundation: irys-types, irys-config, irys-database
Domain: irys-domain (BlockTree, BlockIndex, StorageModule, SupplyState)🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 48-48: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
In `@CLAUDE.md` around lines 46 - 55, Add a language identifier to the fenced code
block under the "### Crate Dependency Layers" heading so markdown linters and
syntax highlighters treat it as plain text; locate the triple-backtick block
that contains the Foundation/Domain/Services/etc. lines and change the opening
fence from ``` to ```text (or ```plaintext) to explicitly specify the language.
JesseTheRobot
left a comment
There was a problem hiding this comment.
One minor change, otherwise LGTM
Describe the changes
Checklist
Summary by CodeRabbit