fix(tempo): add sensible tempo limits#1160
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdjusted Tempo observability configuration and Docker deployment: decreased ingester max_block_duration, added ingester max_block_bytes, and added a 4G memory limit to the Tempo service in docker-compose. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docker/observation/configs/tempo/tempo.yaml`:
- Line 60: The tempo processors list currently omits the local-blocks processor
which TraceQL metrics require; either re-add local-blocks to the processors
array in tempo.yaml (restore "local-blocks" alongside "service-graphs" and
"span-metrics") to keep TraceQL metrics working, or disable the traceqlEditor
toggle in the Grafana service's GF_FEATURE_TOGGLES_ENABLE environment value in
docker-compose.yaml (remove "traceqlEditor" from that comma-separated list) so
the editor is not exposed when local-blocks is not enabled.
In `@docker/observation/docker-compose.yaml`:
- Around line 57-60: The compose file currently sets a hard memory cap via
deploy.resources.limits.memory: 4G but should also declare CPU limit and a
memory reservation to provide a guaranteed floor; update the service's deploy
block (deploy.resources) to add limits.cpus (or cpus) and reservations.memory so
the scheduler has both a ceiling and a reservation — modify the same
deploy.resources.limits and add a deploy.resources.reservations.memory entry and
a deploy.resources.limits.cpus entry for the service to enforce CPU and
reservation alongside the 4G memory limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
A clear and concise description of what the bug fix, feature, or improvement is.
Related Issue(s)
Please link to the issue(s) that will be closed with this PR.
Checklist
Additional Context
Add any other context about the pull request here.
Summary by CodeRabbit