fix(ci): drop literal expression from docker-setup input description#1427
Merged
Conversation
The `username` input description contained a literal ${{ github.actor }}
example. GitHub's action manifest loader evaluates expressions even inside
description text, and the github context is unavailable at load time, so the
whole composite action fails to load with "Unrecognized named-value: 'github'".
This broke the "Start rootless Docker and log in to GHCR" step in every job
that uses the action (release, docker, devnet) — caught by a testnet dry-run.
Refer to the context by name only; the real `username: ${{ github.actor }}`
lives in the calling workflows, where it's valid.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRemove embedded Action expressions from the docker-setup action input description; add GIT_CLIFF_TAG_PATTERN and RUST_LOG=git_cliff_core=trace to the release changelog step; clarify tag-pattern behavior in .config/cliff.toml. ChangesGitHub Action documentation
Release workflow and git-cliff config
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The changelog step logs "N commit(s) skipped due to parse error" without naming them. Pass -vv so git-cliff logs each non-conventional/unparseable commit (e.g. a commit missing a `type:` prefix) to stderr — visible in the Actions log. Output is unaffected; the changelog still goes to OUTPUT.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ac04f3d | Previous: 76f9ed4 | Ratio |
|---|---|---|---|
parallel_verification/testing |
0.096997 ms/iter (± 0.023328) |
0.034066 ms/iter (± 0.000508) |
2.85 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
Benchmark results: https://irys-xyz.github.io/irys/dev/bench/fix%2Frelease-process/index.html |
-vv enables global TRACE, which floods the changelog log with thousands of hyper/HTTP lines from git-cliff's GitHub remote-data fetch and truncates before the useful line. RUST_LOG=git_cliff_core=trace names each skipped/non-conventional commit (e.g. the missing-`type:` commit) without the noise.
Each release's notes should span since the previous release of the SAME environment: testnet-X.Y.Z since the last testnet-*, mainnet-X.Y.Z since the last mainnet-*. The prior `--ignore-tags ^testnet-` (mainnet) didn't achieve this: git-cliff's --unreleased anchors the commit range to the latest reachable version tag, and --ignore-tags only relabels the "previous" link without moving the range. With both testnet-0.2.0 and the newer mainnet-0.1.3 reachable from the 3.x line, a testnet release wrongly spanned since mainnet-0.1.3. Override tag_pattern per env via GIT_CLIFF_TAG_PATTERN so --unreleased anchors to the env's own previous tag (verified: testnet-3.0.0 -> previous testnet-0.2.0). First release of an env (no prior tag) spans full history, as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usernameinput description in.github/actions/docker-setup/action.yamlcontained a literal${{ github.actor }}example.${{ }}expressions even insidedescriptiontext, and thegithubcontext isn't available at load time — so the composite action fails to load withUnrecognized named-value: 'github'.release.yml,docker.yml,devnet.yml). The realusername: ${{ github.actor }}lives in the calling workflows, where it's valid — only the description needed fixing.How it was found
A testnet
dry_run=trueofrelease.ymlgot through all validation and started the build/publish job (no approval prompt — env-gate skip works), then failed at docker-setup with the manifest load error.Test plan
gh workflow run release.yml --ref fix/release-process -f release_type=testnet -f version=3.0.0 -f commit=<release/testnet/3.x tip> -f dry_run=trueSummary by CodeRabbit