crates/p2p/src/types.rs (1)

754-768: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add ChainIdMismatch to the v1/v2 consistency test.

The test validates that non-HandshakeRequired variants serialize identically through both envelopes. ChainIdMismatch is a unit variant and should be included to prevent future regressions.

✅ Proposed fix

     fn rejected_v2_json_matches_v1_for_non_handshake_variants() {
         for reason in [
             RejectionReason::GossipDisabled,
             RejectionReason::InvalidData,
             RejectionReason::RateLimited,
             RejectionReason::UnableToVerifyOrigin,
             RejectionReason::InvalidCredentials,
             RejectionReason::ProtocolMismatch,
             RejectionReason::UnsupportedFeature,
+            RejectionReason::ChainIdMismatch,
             RejectionReason::UnsupportedProtocolVersion(7),
         ] {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/p2p/src/types.rs` around lines 754 - 768, The test
rejected_v2_json_matches_v1_for_non_handshake_variants is missing the
RejectionReason::ChainIdMismatch unit variant; update the array of reasons in
that test to include RejectionReason::ChainIdMismatch so
GossipResponse::<()>::Rejected(reason) serialization via serde_json::to_value
still matches rejected_v2_json(reason) for that case and prevents future
regressions.

crates/p2p/src/gossip_client.rs (1)

959-969: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Handle ChainIdMismatch as unhealthy in check_health.

With the new rejection reason, this branch currently falls into _ and still returns Ok(true), so different-network peers can be kept online/eligible. Treat RejectionReason::ChainIdMismatch as terminal unhealthy (same class as network/protocol mismatch handling intent).

Suggested fix

-                    RejectionReason::InvalidCredentials | RejectionReason::ProtocolMismatch => {
+                    RejectionReason::InvalidCredentials
+                    | RejectionReason::ProtocolMismatch
+                    | RejectionReason::ChainIdMismatch => {
                         warn!("Health check rejected with reason: {:?}", reason);
+                        return Ok(false);
                     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/p2p/src/gossip_client.rs` around lines 959 - 969, The health check
currently treats RejectionReason::ChainIdMismatch as non-terminal because it
falls into the wildcard arm and still returns Ok(true); in the check_health
function update the match on RejectionReason so that
RejectionReason::ChainIdMismatch is handled the same as
RejectionReason::InvalidCredentials and RejectionReason::ProtocolMismatch (log a
warning and return Ok(false)) while keeping all other cases returning Ok(true).
Reference the match on RejectionReason inside check_health and add
ChainIdMismatch to that branch so peers from a different chain are marked
unhealthy.