Skip to content

fix: "search" Icon Row Count Increases When "search" Coordinate is Multiple of 4#264

Closed
demopath wants to merge 1 commit intoIsrothy:mainfrom
demopath:main
Closed

fix: "search" Icon Row Count Increases When "search" Coordinate is Multiple of 4#264
demopath wants to merge 1 commit intoIsrothy:mainfrom
demopath:main

Conversation

@demopath
Copy link
Copy Markdown
Contributor

When the "search" coordinate is a multiple of 4, the "search" icon has one extra row.
This happens when current_line_position is "center" or "percent".
So, the issue likely lies with the "search" coordinate's row.
I’m unsure of the exact bug cause; I just observed the numerical pattern across all rows.

image image image

@demopath demopath force-pushed the main branch 2 times, most recently from f688da8 to 86fb446 Compare September 24, 2025 20:38
@Isrothy
Copy link
Copy Markdown
Owner

Isrothy commented Sep 24, 2025

I have some difficulty repreducing this problem. Could you share with me a minimal configuration?

@Isrothy
Copy link
Copy Markdown
Owner

Isrothy commented Sep 24, 2025

Fixed

@Isrothy Isrothy closed this Sep 24, 2025
@demopath
Copy link
Copy Markdown
Contributor Author

minimal configuration

local lazytab = {{
    "Isrothy/neominimap.nvim",
    version = "v3.x.x",
    lazy = false, 
    init = function()
        vim.g.neominimap = {
            auto_enable = true,
            search = {
                enabled  = true,
                mode     = "icon",
            },
        }
    end,
}, 

}

lazyload = function(plugins)
    if not plugins or #plugins < 1 then return end
    local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
    if not (vim.uv or vim.loop).fs_stat(lazypath) then
        local lazyrepo = "https://github.com/folke/lazy.nvim.git"
        vim.fn.system({ "git", "clone", "--filter=blob:none", "--branch=stable", lazyrepo, lazypath })
        if vim.v.shell_error ~= 0 then return end
    end
    vim.opt.rtp:prepend(lazypath)
    require("lazy").setup({
        spec = plugins,
        checker = { enabled = false }, 
    })
    require('lazy.view.config').keys.hover = '<Tab>'
end

lazyload(lazytab)

@demopath
Copy link
Copy Markdown
Contributor Author

It's amazing, did this fix originally not require special handling for multiples of 4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants