Skip to content

Inline images causing differing line separations #607

Description

@tinkerer-red

As an example here are two examples, one with a 16 pixel high glyph set, and another with 32. the font is the same in every way

16:
Image
32:
Image

This appears to be because of a magic number 2. Here and Here. Nothing seems like it needs that additional support, as the lines are already broken by the highest and lowest glyph and not by the fonts line height.

Removing this number gives us this:
Image

Activity

  1. JujuAdams commented on Mar 25, 2025

    @JujuAdams
    Owner

    Magic numbers exist for a reason. I'll need to search back through commits to figure out why. Likely something to do with fa_middle vertical alignment.

  2. changed the title [-]inline images causing differing line separations[/-] [+]Inline images causing differing line separations[/+] on Mar 25, 2025
  3. tinkerer-red commented on Mar 25, 2025

    @tinkerer-red
    ContributorAuthor

    To save you a bit of time it was commit: 4e25cbe and the previous: b2f4fb4
    They are initial tests for inline macros, and the 2 tested sprites both also have exactly 2 missing pixels (1 on top 1 on bottom), ehhh... I'm not a betting man. But its probably just an oversight. I'd need to get an older version of gm to accurately compile it though and see what the test was, it doesn't compile on modern monthly.

  4. added this to the 10.0 milestone on Aug 21, 2025
  5. WangleLine commented on Sep 30, 2026

    @WangleLine

    it looks like the +2 was just for spr_large_coin and spr_coin having transparent borders

  6. WangleLine commented on Sep 30, 2026

    @WangleLine

    @tinkerer-red do you still have the project the screenshots in your issue are from?

    if you remove the +2 from the var _scale = [etc etc] @ SCRIBBLE_AUTOFIT_INLINE_SURFACES and SCRIBBLE_AUTOFIT_INLINE_TEXTURES, does it fix your issue?

  7. WangleLine commented on Sep 30, 2026

    @WangleLine

    for the +2 removal, I made this PR: #712

    and while tryin to debug this I also got this: #713

  8. WangleLine commented on Sep 30, 2026

    @WangleLine

    First PR solves the line height drifting, second PR fixes sprites having the wrong y offset in sprite align mode 2

    Image
  9. tinkerer-red commented on Oct 1, 2026

    @tinkerer-red
    ContributorAuthor

    @WangleLine Yes that project is my Emobble extension for Scribble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 😅Juju did a bad thing

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions