Fix sampling method reset#13
Merged
Merged
Conversation
Remove "Custom" option and improve default value handling when changing sampling methods. Co-authored-by: johndavidpressman <johndavidpressman@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: johndavidpressman <johndavidpressman@gmail.com>
Co-authored-by: johndavidpressman <johndavidpressman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve user-entered values in the service settings modal when changing sampling methods and remove the legacy "Custom" option.
Previously, changing the sampling method would reset all related fields (API URL, Model Name, API Delay) to the new method's defaults, even if the user had already entered custom values. This change implements a "smart" default replacement, only updating fields if their current value is empty or matches the default of the previous sampling method, thus preserving user input. The "Custom" sampling method was also removed as it is legacy.