fix: dismiss ROM detail sidebar by re-clicking selected ROM#176
Merged
Conversation
Clicking an already-selected ROM now deselects it, closing the detail sidebar. Previously there was no way to close the sidebar without restarting the app. Closes #169 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Behavior looks correct for the described UX, but the new selection logic is a dense inline ternary that would be clearer as a named boolean or explicit conditional.
Additional notes (1)
- Readability |
src/components/RomList.vue:100-101
The inline ternary makes the “re-click to deselect” behavior a bit hard to scan/extend (especially if more selection rules are added later). A small, named boolean or an explicitifreads clearer and is easier to debug.
Summary of changes
What changed
- Updated
handleRomClickso a plain click on a ROM that is already the sole selected ROM toggles selection off by emitting[](closing the detail sidebar). - Preserved existing behaviors for Ctrl/Cmd-click (toggle) and Shift-click (range selection).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Plain-clicking an already-selected ROM now deselects it, which closes the detail sidebar. Previously a plain click always set the selection, so once the sidebar opened there was no way to close it.
Why?
Reported by a community member — after clicking a ROM, the sidebar stays open with no dismiss mechanism. The only workaround was restarting the app. Closes #169
How to test