Add support for Flatpak automatic generation #20
Conversation
dc78b9d to
4104077
Compare
|
For reference, the generate binary is only ~1.5MB big! (this is possible as all the Qt libraries are manage by flatpak as shared runtimes, thus massively reducing the size of the package) |
JamesMcCrae
left a comment
There was a problem hiding this comment.
This seems like a great initiative, as it will streamline distribution of latest releases on Linux moving forward. A few comments just relating to further removal of Network/Webengine from these automation files, and then happy to approve the changes.
CMakeLists.txt
Outdated
| set(CMAKE_AUTOUIC ON) | ||
|
|
||
| find_package(Qt5 COMPONENTS Core Gui OpenGL Widgets Network WebEngineWidgets REQUIRED) | ||
| find_package(Qt5 COMPONENTS Core Gui OpenGL Widgets Network REQUIRED) |
There was a problem hiding this comment.
Can "Network" also be removed here?
CMakeLists.txt
Outdated
| Qt5::Gui | ||
| Qt5::OpenGL | ||
| Qt5::Widgets | ||
| Qt5::Network |
README.md
Outdated
| - install `flatpak` and `flatpak-builder` | ||
| - `flatpak install org.kde.Sdk/x86_64/5.15-24.08` | ||
| - `flatpak install org.kde.Platform/x86_64/5.15-24.08` | ||
| - `flatpak install io.qt.qtwebengine.BaseApp/x86_64/5.15-24.08` |
There was a problem hiding this comment.
Should this line be removed, as it appears specific to webengine?
|
Re: GLU library issue, where does the Flatpak-generated build look for the library? When I run "ldd FlatFab" locally I get: |
Not needed anymore since d02a3d9
While here, clean up CI/CD script a little
As you might have seen in the flatpak manifest, I build manually libGLU when building the flatpak. The library end up in |
Uses the latest Qt 5.15 runtime; builds manually Eigen and GLU. To build: - install flatpak and flatpak-builder - install kde Sdk and Runtime 5.15-24.08 (cf README) - flatpak-builder --force-clean --install --user flatpak-build com.flatfab.FlatFab.yml Run with: flatpak run com.flatfab.FlatFab
- creates a GitHub release everytime a 'vX.Y.Z' tag is pushed - generates Linux flatpak and upload it to the release
|
@JamesMcCrae : I've renamed the flatpak id from |
Flatpak (https://flatpak.org/) is becoming the dominant application distribution mechanism on Linuxes.
This PR depends on (and indeed, includes) PR #19 and #21 .
This PR:
Example result (on fake tags I created for testing):
TODO:
libGLU.so.1inside of the flatbak container is not found, unclear why, a workaround would be to start FlatFab from a script that add/app/lib64toLD_LIBRARY_PATH)Optional:
@JamesMcCrae please let me know if you think this is a useful direction, and if you feel like providing this kind of distribution channel (this would definitely make it much easier to install and update FlatFab on linux, without having to care too much about the different linux distributions)