Revert Flowplayer for HLS streams#656
Conversation
- Introduced Flowplayer as the primary video player by adding necessary scripts and styles. - Removed Shaka Player UI and related configurations, including the unmute button and its functionality. - Implemented Flowplayer's fullscreen handling and orientation locking for mobile devices. - Added keyboard navigation support with the inclusion of keyboard.min.js. - Introduced qsel.min.js for quality selection functionality.
There was a problem hiding this comment.
Summary of Changes
Hello @rabilrbl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the video player implementation by migrating from Shaka Player to Flowplayer. This change streamlines the player setup, removes custom unmute overlay logic, and updates fullscreen orientation handling, along with necessary dependency changes.
Highlights
- Player Migration: Replaced Shaka Player with Flowplayer for video playback.
- UI Simplification: Eliminated the custom unmute overlay button and its associated JavaScript logic.
- Fullscreen Behavior: Updated fullscreen orientation management to leverage Flowplayer's event system, ensuring proper landscape lock on mobile devices during fullscreen and unlock upon exit.
- Dependency Updates: Introduced new external dependencies including Flowplayer core, HLS.js, and Flowplayer extensions for quality selection (qsel.min.js), audio selection (asel.min.js), and keyboard navigation (keyboard.min.js).
- Code Cleanup: Removed all Shaka Player-related scripts and CSS, simplifying the player's dependency footprint.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully replaces Shaka Player with Flowplayer, simplifying the video player implementation. The changes are well-structured, and the new Flowplayer integration is mostly correct. I've found a typo in the Flowplayer configuration and some redundant code that can be simplified. Please see my comments for details.
This pull request replaces the Shaka Player-based video player implementation in
player_hls.htmlwith Flowplayer, streamlining the player setup and removing custom unmute overlay logic. The update also changes the way fullscreen orientation is handled and updates the external dependencies accordingly.Migration from Shaka Player to Flowplayer:
web/views/player_hls.html)web/views/player_hls.html)UI and Feature Adjustments:
web/views/player_hls.html)web/views/player_hls.html)- Introduced Flowplayer as the primary video player by adding necessary scripts and styles.