CMake: Define gammaray_pch_core_gui as an INTERFACE library#940
Conversation
1a6a448 to
f792a52
Compare
An INTERFACE library avoids actual compilation and more complex dependency relation of a STATIC library.
f792a52 to
38f0381
Compare
|
This will make every target have its own PCH resulting in a build that is slower than non-pch build plus a massive increase in the build dir size. |
|
Thank you for taking a look. I was inspired by the following excerpt from the target_precompile_headers doc:
Comparison of running times of GitHub Actions suggests that the compilation time indeed increased. E.g. https://github.com/KDAB/GammaRay/actions/runs/7637161294/job/20805489439?pr=941 vs https://github.com/KDAB/GammaRay/actions/runs/7645378040/job/20831803946?pr=940. I will investigate further. |
|
You were correct, I misunderstood the doc. |
INTERFACE avoids actual compilation and more complex dependency relation of a STATIC library.