rp2040: Check for i2c NACK/Start NACK (#6692) #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, RP2040 silently ignores any kind of errors, and we only try to catch them by timeout condition.
I did some tests, write can't be timeouted actually, at least with a disconnected device.
So, these are specific checks for NACK.
I did reproduce Start NACK/Start Read NACK by disconnecting SDA line from the device.
Write NACK has not been tested, I'm a little puzzled about how to reproduce write NACK.
Klipper PR: Klipper3d/klipper#6692