Skip to content

Conversation

@mr-cheffy
Copy link

No description provided.

@mr-cheffy
Copy link
Author

  1. made the header file a bit better
  2. msprint can now print to other streams, not just stdout (default: stdout).

@Khhs167
Copy link
Owner

Khhs167 commented Jun 12, 2023

Honestly didn't see this til' now, sorry about that!

I like the idea, but I personally have a couple issues with it:

  • Macro magic. Instead of defining some messy functions and making a macro for msprint, I'd personally reccomend having a msprint and msfprint or something in that direction.
  • stdbool. It is included once and never used, remove that for me will ya?

@mr-cheffy
Copy link
Author

I added stdbool because I noticed you defined TRUE and FALSE macros. I will change the macro hell into different functions 👍🏽

@mr-cheffy
Copy link
Author

Please notice that the docstrings you included in the source file is not actually being detected by any sort of documentation generator. I would recomend moving those comments to the header file.

Copy link
Owner

@Khhs167 Khhs167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things that I pointed out, but otherwise this is looking great!

@mr-cheffy mr-cheffy requested a review from Khhs167 June 12, 2023 19:55
Copy link
Owner

@Khhs167 Khhs167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine by me.

@Khhs167 Khhs167 merged commit ac10c58 into Khhs167:master Jun 12, 2023
@mr-cheffy mr-cheffy deleted the patch-1 branch June 12, 2023 19:58
@mr-cheffy
Copy link
Author

thank-you

@Khhs167 Khhs167 mentioned this pull request Jun 13, 2023
@Khhs167 Khhs167 added this to the Next Release(1.3.0/1.2.1) milestone Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants