Load build comments via GraphQL#3475
Conversation
josephsnyder
left a comment
There was a problem hiding this comment.
The add comment functionality needs some work. There's no longer feedback that a comment was added to the page, nor does the comment load automatically. Looking at the developer tools, the GraphQL network call has the response as expected but the comment itself doesn't appear until page refresh.
We've also lost the status of comment that appears on each entry. Is that intentional?
04a2eea to
9ee14df
Compare
|
@josephsnyder The list now gets reloaded after adding new comments.
Yes, I intentionally did not expose the status via GraphQL because I think it no longer provides any value, given that most users are also using GitHub, GitLab, or similar to track issues. |
|
Thanks for the information. It might be best if the dropdown to select that type is removed, since it means nothing now. Though, I can see a type still makes it to the database. |
9ee14df to
96549a9
Compare
|
@josephsnyder The status dropdown has now been removed. I'm planning to replace the comment creation process in a follow-up PR. I'll create a separate PR to address the broken comment link. |
josephsnyder
left a comment
There was a problem hiding this comment.
Thanks for all the information! This one LGTM!
Incremental progress towards our eventual removal of the legacy API in favor of GraphQL. This PR exposes comments via GraphQL and updates the build summary page to use the new GraphQL fields.